gitea-admin/proxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: prove profile diagnostics do not read symlink targets

Browse Source
This commit is contained in:
proxyctl coordinator
2026-07-17 11:42:37 +08:00
parent e9ff24e04a
commit 8a56d19c34
1 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/profile/diagnostic_test.go
+13 -8
View File
@@ -6,6 +6,7 @@ import (
"strings" "strings"
"syscall" "syscall"
"testing" "testing"
"time"
"proxyctl/internal/profile" "proxyctl/internal/profile"
) )
@@ -111,6 +112,9 @@ func TestReadOnlyLoadRejectsSymlinksWithoutReadingOrChangingVictim(t *testing.T)
if err := os.WriteFile(victim, []byte(content), 0o640); err != nil { if err := os.WriteFile(victim, []byte(content), 0o640); err != nil {
t.Fatal(err) t.Fatal(err)
} }
if err := os.Chtimes(victim, time.Unix(1, 0), time.Now()); err != nil {
t.Fatal(err)
}
before := fileIdentity(t, victim) before := fileIdentity(t, victim)
path := test.path(t, t.TempDir(), victim) path := test.path(t, t.TempDir(), victim)
@@ -121,6 +125,10 @@ func TestReadOnlyLoadRejectsSymlinksWithoutReadingOrChangingVictim(t *testing.T)
if strings.Contains(err.Error(), "parse Profile configuration") { if strings.Contains(err.Error(), "parse Profile configuration") {
t.Fatalf("ReadOnlyLoad followed and parsed the victim: %v", err) t.Fatalf("ReadOnlyLoad followed and parsed the victim: %v", err)
} }
after := fileIdentity(t, victim)
if before != after {
t.Fatalf("victim was read or its metadata changed: before=%+v after=%+v", before, after)
}
got, readErr := os.ReadFile(victim) got, readErr := os.ReadFile(victim)
if readErr != nil { if readErr != nil {
t.Fatal(readErr) t.Fatal(readErr)
@@ -128,10 +136,6 @@ func TestReadOnlyLoadRejectsSymlinksWithoutReadingOrChangingVictim(t *testing.T)
if string(got) != content { if string(got) != content {
t.Fatalf("victim content changed to %q", got) t.Fatalf("victim content changed to %q", got)
} }
after := fileIdentity(t, victim)
if before != after {
t.Fatalf("victim metadata changed: before=%+v after=%+v", before, after)
}
if _, statErr := os.Lstat(path + ".lock"); !os.IsNotExist(statErr) { if _, statErr := os.Lstat(path + ".lock"); !os.IsNotExist(statErr) {
t.Fatalf("ReadOnlyLoad created a lock: %v", statErr) t.Fatalf("ReadOnlyLoad created a lock: %v", statErr)
} }
@@ -140,9 +144,10 @@ func TestReadOnlyLoadRejectsSymlinksWithoutReadingOrChangingVictim(t *testing.T)
} }
type diagnosticFileIdentity struct { type diagnosticFileIdentity struct {
mode os.FileMode mode os.FileMode
uid uint32 uid uint32
gid uint32 gid uint32
atime syscall.Timespec
} }
func fileIdentity(t *testing.T, path string) diagnosticFileIdentity { func fileIdentity(t *testing.T, path string) diagnosticFileIdentity {
@@ -155,5 +160,5 @@ func fileIdentity(t *testing.T, path string) diagnosticFileIdentity {
if !ok { if !ok {
t.Fatalf("stat data has type %T", info.Sys()) t.Fatalf("stat data has type %T", info.Sys())
} }
return diagnosticFileIdentity{mode: info.Mode(), uid: stat.Uid, gid: stat.Gid} return diagnosticFileIdentity{mode: info.Mode(), uid: stat.Uid, gid: stat.Gid, atime: stat.Atim}
} }