pi-agent: Fix final integrated review

internal/app/app.go

@@ -19,7 +19,6 @@ const (
 	UpdateProfile
 	DeleteProfile
 	ActivateProfile
-	SetTargetDesired // retained for synchronous compatibility; interactive callers use the explicit intents below.
 	RefreshTargets
 	EnableTarget
 	DisableTarget
@@ -34,7 +33,6 @@ type Intent struct {
 	Profile  profile.Profile
 	Confirm  bool
 	TargetID string
-	Enabled  bool
 }
 
 // TargetActionKind identifies a Target action independently of display labels.
@@ -726,9 +724,6 @@ func (a *Application) refreshInspections() {
 }
 
 func isTargetMutationIntent(kind IntentKind) bool {
-	if kind == SetTargetDesired {
-		return true
-	}
 	for _, policy := range targetActionPolicies {
 		if policy.intent == kind {
 			return true
@@ -737,10 +732,7 @@ func isTargetMutationIntent(kind IntentKind) bool {
 	return false
 }
 
-func requestedTargetAction(intent Intent, selected TargetSnapshot) (TargetActionKind, bool) {
-	if intent.Kind == SetTargetDesired {
-		return legacyTargetAction(intent.Enabled, selected.State)
-	}
+func requestedTargetAction(intent Intent) (TargetActionKind, bool) {
 	for _, policy := range targetActionPolicies {
 		if policy.intent == intent.Kind {
 			return policy.kind, true
@@ -749,17 +741,6 @@ func requestedTargetAction(intent Intent, selected TargetSnapshot) (TargetAction
 	return 0, false
 }
 
-// legacyTargetAction is the only compatibility boundary for the former
-// SetTargetDesired boolean contract. All current callers use TargetActionKind.
-func legacyTargetAction(enabled bool, state target.State) (TargetActionKind, bool) {
-	for _, policy := range targetActionPolicies {
-		if policy.intent != 0 && policy.state == state && policy.desired == enabled {
-			return policy.kind, true
-		}
-	}
-	return 0, false
-}
-
 func structuredTargetAction(selected TargetSnapshot, kind TargetActionKind) (TargetAction, bool) {
 	if selected.PrimaryAction.Kind == kind {
 		return selected.PrimaryAction, true
@@ -773,7 +754,7 @@ func structuredTargetAction(selected TargetSnapshot, kind TargetActionKind) (Tar
 }
 
 func validateTargetAction(intent Intent, selected TargetSnapshot) (targetActionPolicy, error) {
-	kind, ok := requestedTargetAction(intent, selected)
+	kind, ok := requestedTargetAction(intent)
 	if !ok {
 		return targetActionPolicy{}, fmt.Errorf("Target %q action is no longer available because its state is %s", selected.ID, selected.State)
 	}